On 2012/09/08 03:50:06, Mark Mentovai wrote:
> I don’t see the property update here for gmock, probably because Rietveld or
gcl
> is awful with properties. Can you show me your svn stat and svn diff?
svn diff shows the same as the raw patch set.
$ svn pg svn:externals src
testing -r408 http://googlemock.googlecode.com/svn/trunk
$ svn stat|grep -v '^?'
M Makefile.am
M Makefile.in
M src
X src/testing
M src/processor/disassembler_x86_unittest.cc
X src/tools/gyp
M src/common/stabs_reader_unittest.cc
X src/third_party/lss
X src/third_party/glog
X src/third_party/protobuf/protobuf
Performing status on external item at 'src/third_party/lss'
Performing status on external item at 'src/third_party/glog'
Performing status on external item at 'src/third_party/protobuf/protobuf'
X src/third_party/protobuf/protobuf/gtest
Performing status on external item at 'src/third_party/protobuf/protobuf/gtest'
Performing status on external item at 'src/testing'
X src/testing/gtest
Performing status on external item at 'src/testing/gtest'
Performing status on external item at 'src/tools/gyp'
On 2012/09/10 18:21:40, Mark Mentovai wrote:
> I don’t see any properties in the raw patch set, but as long as you’ve got the
> svn:externals you sent by e-mail in there, LGTM
Ya, I don't know why gcl hates me.
$ gcl changes
--- Changelist warning:
M src/common/stabs_reader_unittest.cc
M src/processor/disassembler_x86_unittest.cc
M Makefile.am
M Makefile.in
M src
committed as r1034.
Issue 448002: Fix compiler warnings on Ubuntu Precise. Pull in gmock r408 in the process.
(Closed)
Created 12 years, 10 months ago by Lei Zhang (chromium)
Modified 12 years, 10 months ago
Reviewers: Mark Mentovai
Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Comments: 0