Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(388)

Issue 448002: Fix compiler warnings on Ubuntu Precise. Pull in gmock r408 in the process. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by Lei Zhang (chromium)
Modified:
12 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix compiler warnings on Ubuntu Precise. Pull in gmock r408 in the process.

BUG=490
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 20 chunks +44 lines, -20 lines 0 comments Download
M Makefile.in View 42 chunks +113 lines, -43 lines 0 comments Download
M src/common/stabs_reader_unittest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M src/processor/disassembler_x86_unittest.cc View 2 chunks +50 lines, -51 lines 0 comments Download

Messages

Total messages: 5
Lei Zhang (chromium)
We haven't updated gmock and gtest in a long time. If we pull in the ...
12 years, 2 months ago #1
Mark Mentovai
I don’t see the property update here for gmock, probably because Rietveld or gcl is ...
12 years, 2 months ago #2
Lei Zhang (chromium)
On 2012/09/08 03:50:06, Mark Mentovai wrote: > I don’t see the property update here for ...
12 years, 2 months ago #3
Mark Mentovai
I don’t see any properties in the raw patch set, but as long as you’ve ...
12 years, 2 months ago #4
Lei Zhang (chromium)
12 years, 2 months ago #5
On 2012/09/10 18:21:40, Mark Mentovai wrote:
> I don’t see any properties in the raw patch set, but as long as you’ve got the
> svn:externals you sent by e-mail in there, LGTM

Ya, I don't know why gcl hates me.

$ gcl changes

--- Changelist warning:
M      src/common/stabs_reader_unittest.cc
M      src/processor/disassembler_x86_unittest.cc
M      Makefile.am
M      Makefile.in
 M     src

committed as r1034.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted