Issue 446003: Fix compilation of linux crash_generation_server.cc, and add it to the client library sources so it…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 446003: Fix compilation of linux crash_generation_server.cc, and add it to the client library sources so it… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Ted Mielczarek

Modified:
11 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

On Linux crash_generation_server.cc doesn't get built as part of the client libs
on Linux so it broke and nobody noticed. This patch has a fix for it plus adds
it to the Makefile so it will get built from now on.

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	Makefile.am	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	Makefile.in	View	30 chunks	+104 lines, -71 lines	0 comments	Download
M	aclocal.m4	View	12 chunks	+49 lines, -27 lines	0 comments	Download
M	configure	View	110 chunks	+307 lines, -259 lines	0 comments	Download
M	src/client/linux/crash_generation/crash_generation_server.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

http://breakpad.appspot.com/446003/diff/1/Makefile.am File Makefile.am (right): http://breakpad.appspot.com/446003/diff/1/Makefile.am#newcode1 Makefile.am:1: ## Process this file with automake to produce Makefile.in ...

11 years, 7 months ago #2

Ted Mielczarek

On 2012/09/12 19:09:16, Mark Mentovai wrote: > Again, fix the change description. Once you do, ...

11 years, 7 months ago #3

The automake stuff is fine. LGTM.

Expand All Messages | Collapse All Messages