Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 321 - 340 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
524002	Fix some issues with -Werror=sign-compare on Android builds (Closed)	Ted Mielczarek	digit, digit1		13 years, 1 month
518002	Add API to find out if there is crash reports to send to the server. (Closed)	qsr	Mark Mentovai	2	13 years, 1 month
523002	Remove a call to new[] from WriteDSODebugStream (Closed)	Ted Mielczarek	Mark Mentovai, Lei Zhang (chromium)		13 years, 1 month
516003	Fix remaining processor/scoped_ptr.h references for reals. (Closed)	Lei Zhang (chromium)	Ted Mielczarek		13 years, 1 month
516002	Fix remaining processor/scoped_ptr.h references after r1096. (Closed)	Lei Zhang (chromium)	Ted Mielczarek		13 years, 1 month
512002	Make DumpSymbols methods take a vector of debug_dirs (Closed)	Ted Mielczarek	jimb, Mark Mentovai, Lei Zhang (chromium)	2	13 years, 1 month
515002	Remove <(library) usage from gyp files. (Closed)	Lei Zhang (chromium)	tfarina		13 years, 1 month
510002	Provide a ReadSymbolData function from dump_symbols.cc (Closed)	Ted Mielczarek	jimb, Mark Mentovai, Lei Zhang (chromium)	1	13 years, 1 month
511002	Don't make MmapWrapper's destructor assert (Closed)	Ted Mielczarek	Mark Mentovai		13 years, 1 month
509003	Fix some warnings in stack_frame_symbolizer (Closed)	Ted Mielczarek	siyangxie		13 years, 1 month
509002	Move scoped_ptr.h to common (Closed)	Ted Mielczarek	Mark Mentovai	1	13 years, 1 month
505002	Updating BreakpadController to allow start and stop being nop. (Closed)	qsr	Mark Mentovai, glider, qsr1	2	13 years, 2 months
506002	Fix typo. (Closed)	qsr	Mark Mentovai		13 years, 2 months
504002	Fix minidump size limit used for MinidumpSizeLimit unittest (Closed)	Michael Krebs	Ivan Penkov		13 years, 3 months
503002	Mac/iOS Breakpad client: exceptions off, no libstdc++ (Closed)	Mark Mentovai	qsr		13 years, 3 months
500002	Google-breakpad processor doesn't recognize and use context records generated by ::RtlCaptureContext (Closed)	Ivan Penkov	Mark Mentovai, Jess, Ted Mielczarek	9	13 years, 3 months
501002	Allow StackwalkerARM to scan much farther to find caller of context frame (Closed)	Ted Mielczarek	jimb, Michael Krebs	2	13 years, 3 months
499003	Add assertion on initialization sequence. (Closed)	qsr	Mark Mentovai		13 years, 3 months
499002	Fix unused variable warning in optimized build (fix proveded by Matthew Riley) (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, Jess		13 years, 3 months
488002	Cleaning up google-breakpad source code of signed-unsigned comparison warnings (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai	6	13 years, 3 months

« Newest ‹ Newer 321 - 340 Older ›