Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(132)

Issue 510002: Provide a ReadSymbolData function from dump_symbols.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by Ted Mielczarek
Modified:
7 years, 6 months ago
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

We have a use case where we'd like to read symbol data and use it directly,
without having to serialize it to a file. Step 1 is to provide an API to get the
data out in non-serialized form. This patch adds a ReadSymbolData function to
dump_symbols.cc which returns a Module object and refactors things slightly to
avoid code duplication.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/dump_symbols.cc View 5 chunks +34 lines, -18 lines 0 comments Download
M src/common/linux/dump_symbols.h View 1 chunk +10 lines, -0 lines 1 comment Download
M src/common/linux/dump_symbols_unittest.cc View 4 chunks +28 lines, -20 lines 0 comments Download

Messages

Total messages: 3
Ted Mielczarek
7 years, 7 months ago #1
Ted Mielczarek
jimb is tied up in other work currently, so trolling for reviews. I have a ...
7 years, 6 months ago #2
Lei Zhang (chromium)
7 years, 6 months ago #3
lgtm

https://breakpad.appspot.com/510002/diff/1/src/common/linux/dump_symbols.h
File src/common/linux/dump_symbols.h (right):

https://breakpad.appspot.com/510002/diff/1/src/common/linux/dump_symbols.h#ne...
src/common/linux/dump_symbols.h:58: // As above, but simply return the debugging
information in module
nit: module in caps?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted