Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(140)

Issue 511002: Don't make MmapWrapper's destructor assert (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by Ted Mielczarek
Modified:
7 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

MmapWrapper's destructor currently asserts that it was set. Some of our upcoming
patches will change behavior such that it can wind up not being set, which trips
this assertion. The cleanup code already checks the state of the members it
touches, so I don't think this hurts anything.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/dump_symbols.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
7 years, 7 months ago #1
Mark Mentovai
7 years, 7 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted