Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(333)

Issue 509002: Move scoped_ptr.h to common (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by Ted Mielczarek
Modified:
11 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

I have another patch in common code in which I'd like to use scoped_ptr. This
patch is just a rename and fixing up #includes

Patch Set 1 #

Total comments: 1

Patch Set 2 : Oops, good catch. Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/ios/BreakpadController.mm View 1 chunk +1 line, -1 line 0 comments Download
M src/client/ios/handler/ios_exception_minidump_generator.mm View 1 chunk +1 line, -1 line 0 comments Download
M src/client/linux/handler/exception_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/client/mac/handler/exception_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/client/windows/handler/exception_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/common/mac/string_utilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/common/scoped_ptr.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/common/solaris/dump_symbols.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/common/string_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/basic_source_line_resolver_types.h View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/basic_source_line_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/cfi_frame_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/exploitability.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/exploitability_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/fast_source_line_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/minidump.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/processor/minidump_dump.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/minidump_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/minidump_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/minidump_stackwalk.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/module_comparer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/range_map_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/processor/stack_frame_symbolizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_amd64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_selftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_x86.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/static_contained_range_map_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/processor/static_range_map_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/tools/linux/md2core/minidump-2-core.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/tools/mac/crash_report/crash_report.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Ted Mielczarek
11 years, 3 months ago #1
Mark Mentovai
http://breakpad.appspot.com/509002/diff/1/src/common/scoped_ptr.h File src/common/scoped_ptr.h (right): http://breakpad.appspot.com/509002/diff/1/src/common/scoped_ptr.h#newcode49 src/common/scoped_ptr.h:49: #ifndef PROCESSOR_SCOPED_PTR_H__ Fix the guard name.
11 years, 3 months ago #2
Ted Mielczarek
11 years, 3 months ago #3
Ted Mielczarek
On 2013/01/16 20:08:00, Mark Mentovai wrote: > http://breakpad.appspot.com/509002/diff/1/src/common/scoped_ptr.h#newcode49 > src/common/scoped_ptr.h:49: #ifndef PROCESSOR_SCOPED_PTR_H__ > Fix the ...
11 years, 3 months ago #4
Mark Mentovai
11 years, 3 months ago #5
Give it only one trailing underscore and it’s an LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted