Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 121 - 140 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
1464002	Fill in CPU info in mini-dump for Arm64. (Closed)	rmcilroy	Mark Mentovai	9	11 years, 11 months
1564002	Limit the workaround in r1313 to Android only. (Closed)	Lei Zhang (chromium)	vapier, rmcilroy		11 years, 11 months
1524002	[Android]: Fix hang in CreateChildCrash() on Android. (Closed)	rmcilroy	Lei Zhang (chromium), vapier	2	11 years, 11 months
1544002	x64: Update offset of fpregs_mem. (Closed)	anton	Lei Zhang (chromium), rmcilroy		11 years, 11 months
1454002	Add x64 version of getcontext. (Closed)	anton	Lei Zhang (chromium), dannyb, rmcilroy	10	11 years, 11 months
1434002	Adding support for 64-bit Windows modules to ms_symbol_server_converter. (Closed)	ivanpe	Mark Mentovai, Ted Mielczarek, chrisha, Will Harris	8	11 years, 11 months
1504002	Renaming the 'build' directory as it collides with a file named 'BUILD' which is (Closed)	ivanpe	Mark Mentovai, chrisha		11 years, 11 months
1414002	Move build configuration to root of repository. (Closed)	chrisha	Mark Mentovai, ivanpe	7	11 years, 11 months
1484002	Increase Breakpad's signal handler stack size. (Closed)	rmcilroy	Mark Mentovai		11 years, 11 months
1444002	Fix aarch64 ucontext layout on Android (Closed)	rmcilroy	Mark Mentovai		11 years, 11 months
1424002	Add Arm64 support to breakpad unittests. (Closed)	rmcilroy	Mark Mentovai	2	11 years, 11 months
1394002	Update GYP dependency to r1886. (Closed)	chrisha	Mark Mentovai, Will Harris		11 years, 11 months
1404002	Fix ElfCoreDumpTest.ValidCoreFile unit test. (Closed)	Ben Chan	vapier		11 years, 11 months
1384002	Add Arm64 version of breakpad_getcontext for Android. (Closed)	rmcilroy	Mark Mentovai	11	11 years, 11 months
1354002	First cut at adding arm64 Linux / Android support to Breakpad. (Closed)	rmcilroy	Mark Mentovai	13	11 years, 11 months
1374002	Remove some unecessary Android system header definitions. (Closed)	rmcilroy	Mark Mentovai	2	11 years, 11 months
1304005	fix races in CrashGenerator::CreateChildCrash (Closed)	vapier	Ben Chan, vapier1	10	11 years, 11 months
1304004	Update DEPS to bring in gtest, gmock and GYP. (Closed)	chrisha	Mark Mentovai, rsesek	15	11 years, 11 months
1314003	Add .gitignore file. (Closed)	chrisha	Mark Mentovai, rsesek	6	11 years, 11 months
1334002	Terminating FileID path when at maximum length. (Coverity) (Closed)	Lei Zhang (chromium)	cmumford		11 years, 11 months

« Newest ‹ Newer 121 - 140 Older ›