Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 1274002: Add support for Win64 stack unwind data as STACK CFI (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by Will Harris
Modified:
10 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add support for Win64 stack unwind data as STACK CFI

This is a copy of https://breakpad.appspot.com/1264002/ where code review took
place.

See https://bugzilla.mozilla.org/show_bug.cgi?id=548035 and
https://code.google.com/p/chromium/issues/detail?id=115922

Credit to Mikhail I. Izmestev <izmmishao5@gmail.com> for original patch in
https://breakpad.appspot.com/345002/

BUG=572
TEST=Run dump_syms_unittest after compiling dump_syms_regtest.cc with x64
toolchain
R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1290

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/windows/pdb_source_line_writer.cc View 1 3 chunks +191 lines, -1 line 0 comments Download
M src/common/windows/pdb_source_line_writer.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/tools/windows/dump_syms/dump_syms.gyp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/tools/windows/dump_syms/dump_syms_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A src/tools/windows/dump_syms/testdata/dump_syms_regtest64.pdb View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/tools/windows/dump_syms/testdata/dump_syms_regtest64.sym View 1 chunk +4559 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Will Harris
This is a copy of https://breakpad.appspot.com/1264002/ with the correct base for gcl to work correctly.
10 years, 1 month ago #1
Mark Mentovai
LGTM
10 years, 1 month ago #2
Will Harris
10 years, 1 month ago #3
Message was sent while issue was closed.
Committed patchset #2 manually as r1290 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted