Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 345002: Add win64 unwind info

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by izmmisha
Modified:
7 years, 4 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/common/
Visibility:
Public.

Description

Add win64 unwind info

Patch Set 1 #

Patch Set 2 : Add win64 unwind info #

Patch Set 3 : fixed handling UWOP_PUSH_MACHFRAME #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M windows/pdb_source_line_writer.cc View 1 2 3 chunks +195 lines, -1 line 11 comments Download
M windows/pdb_source_line_writer.h View 1 2 1 chunk +10 lines, -0 lines 1 comment Download

Messages

Total messages: 10
Ted Mielczarek
Mark, do you want to take a look at this? It's based on some code ...
9 years, 6 months ago #1
izmmisha
On 2012/01/27 12:40:20, Ted Mielczarek wrote: > Mark, do you want to take a look ...
9 years, 6 months ago #2
Mark Mentovai
Can you make this follow the style guide? Use C++<style>(casts) instead of (original_C)style, this_style variable ...
9 years, 6 months ago #3
izmmisha
On 2012/01/27 18:55:20, Mark Mentovai wrote: > Can you make this follow the style guide? ...
9 years, 6 months ago #4
Ted Mielczarek
The Google style guide is available here, FYI: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
9 years, 6 months ago #5
izmmisha
On 2012/01/27 19:08:15, izmmisha wrote: > On 2012/01/27 18:55:20, Mark Mentovai wrote: > > Can ...
9 years, 6 months ago #6
izmmisha
9 years, 4 months ago #7
izmmisha
UWOP_PUSH_MACHFRAME used in ntdll!RcConsolidateFrames ntdll!KiUserApcDispatch ntdll!KiUserCallbackDispatch ntdll!KiUserExceptionDispatcher
9 years, 4 months ago #8
Ted Mielczarek
I'm sorry I let this sit so long! http://breakpad.appspot.com/345002/diff/9001/windows/pdb_source_line_writer.cc File windows/pdb_source_line_writer.cc (right): http://breakpad.appspot.com/345002/diff/9001/windows/pdb_source_line_writer.cc#newcode54 windows/pdb_source_line_writer.cc:54: #define ...
8 years, 9 months ago #9
Ted Mielczarek
7 years, 4 months ago #10
This has been revived in https://breakpad.appspot.com/1264002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted