Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 441 - 460 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
482002	Fix the Android unit tests. (Closed)	digit	Ted Mielczarek, Mark Mentovai		13 years, 4 months
440002	Properly redeliver (or don't) signals to the previous handlers. (Closed)	cjhopman	Mark Mentovai, digit	30	13 years, 4 months
478005	Workaround incorrect signal handler save/restore (Closed)	cjhopman	Mark Mentovai	5	13 years, 4 months
478002	Don't bail if a thread's stack pointer is invalid (Closed)	Michael Krebs	Ted Mielczarek, Mark Mentovai	4	13 years, 4 months
479003	Comment out the (unused) variable name in the function definition	rafael.espindola	jimb, jimb		13 years, 4 months
478004	Record declaration names when they have a DW_AT_MIPS_linkage_name	rafael.espindola	jimb	2	13 years, 4 months
457002	Use DW_AT_MIPS_linkage_name if it is available. (Closed)	rafael.espindola	Ted Mielczarek, Ryan Sleevi, jimb, jimb	10	13 years, 4 months
475003	Update comment.	rafael.espindola	jimb		13 years, 4 months
477002	remove unused argument (Closed)	rafael.espindola	Ted Mielczarek, jimb		13 years, 4 months
479002	Fix warning "comparing signed and unsigned value"	jakerr	Mark Mentovai, qsr		13 years, 4 months
476002	Update dump_syms to correctly filter on cpu subtype. (Closed)	qsr	Mark Mentovai	10	13 years, 4 months
478003	Fix minor Android build failure with Clang. (Closed)	digit	Mark Mentovai, Ted Mielczarek, qsr		13 years, 4 months
473002	Fix analyzer warning due to value assigned but not read. (Closed)	kenbongort	qsr		13 years, 4 months
475002	Add custom implementation of NXGetArchInfoXXX to allow adding new arch. (Closed)	qsr	Mark Mentovai, Ted Mielczarek	7	13 years, 4 months
460002	Fix linux compile errors for some systems. (Closed)	jakerr	Ted Mielczarek, qsr	5	13 years, 4 months
445002	Fix of a race condition during Crash Generation Server startup (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek		13 years, 4 months
463003	MIPS support for Dump-Syms	deepthi	Ted Mielczarek, jimb	2	13 years, 4 months
470002	Fix the Linux build with clang. (Closed)	Lei Zhang (chromium)	cjhopman, Mark Mentovai		13 years, 4 months
471002	Merge trunk r1050 to chrome_23 branch. (Closed)	Lei Zhang (chromium)			13 years, 4 months
463004	Fix a bunch of small nits. (Closed)	Lei Zhang (chromium)	Mark Mentovai		13 years, 4 months

« Newest ‹ Newer 441 - 460 Older ›