remove unused argument

remove unused argument.

Closed. Apparently dead code is a good thing in some contexts.

[Ted Mielczarek]

Jim should probably take a look at this.

[jimb]

I don't think this patch is a good change.

Because of the structure of DWARF, it's possible to know the set of attributes a
DIE will have, even before we have read their values. It seems reasonable for a
DWARF parser to offer that information to the function that needs to decide
whether or not to parse the DIE. 

It's true that the handlers we have here don't use the data. But the information
is cheap, because we parse the abbreviation table up front. The test suite
covers the behavior.

[rafael.espindola]

Reading the style guide at
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml I found

"If some parameters are unused, comment out the variable name in the function
definition"

Would you be ok with patch doing at least that so that it is immediately obvious
the argument is dead?

[jimb]

On 2012/10/05 18:30:37, rafael.espindola wrote:
> Reading the style guide at
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml I found
> 
> "If some parameters are unused, comment out the variable name in the function
> definition"
> 
> Would you be ok with patch doing at least that so that it is immediately
obvious
> the argument is dead?

In DwarfCUToModule::NamedScopeHandler::FindChildHandler and
DwarfCUToModule::FindChildHandler? Definitely; that's an improvement. But
dwarf2diehandler.cc and dwarf2reader.cc should be left alone.