Issue 463003: MIPS support for Dump-Syms

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 463003: MIPS support for Dump-Syms

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by deepthi

Modified:
11 years, 7 months ago

Reviewers:
Ted Mielczarek, jimb

CC:
chris, google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

MIPS support for Dump-Syms

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/common/dwarf_cfi_to_module.cc	View	1 chunk	+16 lines, -0 lines	1 comment	Download
M	src/common/dwarf_cfi_to_module.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/common/linux/dump_symbols.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/common/linux/elfutils-inl.h	View	1 chunk	+6 lines, -3 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Ted Mielczarek

11 years, 7 months ago #5

http://breakpad.appspot.com/463003/diff/1/src/common/dwarf_cfi_to_module.cc
File src/common/dwarf_cfi_to_module.cc (right):

http://breakpad.appspot.com/463003/diff/1/src/common/dwarf_cfi_to_module.cc#n...
src/common/dwarf_cfi_to_module.cc:118: "$f28", "$f29", "$f30", "$f31", "$fcsr",
"$fir"
nit: the other architectures seem to have the registers on each line vertically
aligned into columns.

http://breakpad.appspot.com/463003/diff/1/src/common/linux/elfutils-inl.h
File src/common/linux/elfutils-inl.h (right):

http://breakpad.appspot.com/463003/diff/1/src/common/linux/elfutils-inl.h#new...
src/common/linux/elfutils-inl.h:66: (sections[i].sh_type == SHT_MIPS_DWARF)) &&
This isn't right, FindElfSectionByName is a generic function. You'll want to
modify the caller instead. Probably this one:
http://code.google.com/p/google-breakpad/source/browse/trunk/src/common/linux...

The simple fix would probably be something like
ElfClass::Word section_type = elf_header->e_machine == EM_MIPS ? SHT_MIPS_DWARF
: SHT_PROGBITS;

Expand All Messages | Collapse All Messages