Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 361 - 380 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
480002	Parse ARM unwind tables	Ted Mielczarek	jimb, vasily.golubev		12 years, 9 months
561003	Move SimpleStringDictionary from common/mac/ to just common/. (Closed)	rsesek	Mark Mentovai	2	12 years, 9 months
554003	Fix missing result check in Mac exception handler	georg.fritzsche	Ted Mielczarek		12 years, 9 months
533002	ESP is zero in dumps created by CrashGenerationClient::RequestDump on i386 Linux	bruce.dawson	ted mielczarek <ted, Ted Mielczarek	4	12 years, 9 months
559002	Change MDRawSystemInfo.processor_architecture value for PPC64 to 0x8002. (Closed)	Lei Zhang (chromium)	Mark Mentovai		12 years, 10 months
558002	Add PPC64 support to breakpad processor. (Closed)	Lei Zhang (chromium)	jijia		12 years, 10 months
555002	fixng build by MSVC 2005/2008 compiler with default Windows SDK	pelekhay	Siggi		12 years, 10 months
554004	Fix build on Android - add a missing NT_GNU_BUILD_ID define. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek, digit	2	12 years, 10 months
553002	Remove auto_ptr usage in Breakpad. (Closed)	Lei Zhang (chromium)	Mark Mentovai		12 years, 10 months
551002	Turn off verbose logging but keep logic for future reference for debug logging. (Closed)	Jess	Ivan Penkov, Mark Mentovai, Ted Mielczarek, Lei Zhang (chromium)		12 years, 10 months
537002	Remove "library" variable. (Closed)	tfarina	Lei Zhang (chromium), Ted Mielczarek		12 years, 10 months
544002	Refactor BasicElf synth_elf unitest (Closed)	glandium	Ted Mielczarek	1	12 years, 10 months
544003	Try to find a build-id through PT_NOTE program headers (Closed)	glandium	Ted Mielczarek	1	12 years, 10 months
545002	Add primitive Elf program header support for synth_elf, with unit tests (Closed)	glandium	Ted Mielczarek	3	12 years, 10 months
546002	Support generic Elf notes, with unit tests (Closed)	glandium	Ted Mielczarek	1	12 years, 10 months
543003	Refactor file_id_unittest (Closed)	glandium	Ted Mielczarek		12 years, 10 months
542003	Add tests for section headers in synth_elf unittest (Closed)	glandium	Ted Mielczarek		12 years, 10 months
543002	Defer adding sections until ELF::Finish in synth_elf (Closed)	glandium	Ted Mielczarek	1	12 years, 10 months
542002	Get the complete linux gate mapping instead of only one page (Closed)	glandium	Ted Mielczarek		12 years, 10 months
547002	Structured logging prerequisites. Wrapping std::ostream with a new type. (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, Josh M.		12 years, 10 months

« Newest ‹ Newer 361 - 380 Older ›