Issue 544002: Refactor BasicElf synth_elf unitest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 544002: Refactor BasicElf synth_elf unitest (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by glandium

Modified:
11 years, 1 month ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Refactor BasicElf synth_elf unitest

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/synth_elf_unittest.cc	View		3 chunks	+23 lines, -49 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ted Mielczarek

LGTM, nice cleanup. https://breakpad.appspot.com/544002/diff/1/src/common/linux/synth_elf_unittest.cc File src/common/linux/synth_elf_unittest.cc (right): https://breakpad.appspot.com/544002/diff/1/src/common/linux/synth_elf_unittest.cc#newcode208 src/common/linux/synth_elf_unittest.cc:208: ELF elf(EM_386, TypeParam::kClass, kLittleEndian); This is ...

11 years, 1 month ago #2

glandium

On 2013/03/29 14:54:35, Ted Mielczarek wrote: > This is kind of unfortunate. Maybe the ELF ...

11 years, 1 month ago #3

Ted Mielczarek

11 years, 1 month ago #4

On 2013/03/30 08:37:53, glandium wrote:
> On 2013/03/29 14:54:35, Ted Mielczarek wrote:
> > This is kind of unfortunate. Maybe the ELF constructor should just set it
> > properly?
> 
> What is "properly"? There are more 32-bits ELF platforms than EM_386, and more
> 64-bits ELF platforms than EM_X86_64.

Sure, but Breakpad only supports x86/x86-64/arm on Linux.

Expand All Messages | Collapse All Messages