Issue 545002: Add primitive Elf program header support for synth_elf, with unit tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 545002: Add primitive Elf program header support for synth_elf, with unit tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by glandium

Modified:
11 years, 1 month ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Add primitive Elf program header support for synth_elf, with unit tests

Patch Set 2 : with review comments addressed #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/common/linux/synth_elf.cc	View	1	4 chunks	+62 lines, -3 lines	0 comments	Download
M	src/common/linux/synth_elf.h	View	1	3 chunks	+12 lines, -4 lines	0 comments	Download
M	src/common/linux/synth_elf_unittest.cc	View		2 chunks	+109 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

Just one thing I'd like to see fixed, LGTM otherwise. https://breakpad.appspot.com/545002/diff/1/src/common/linux/synth_elf.cc File src/common/linux/synth_elf.cc (right): https://breakpad.appspot.com/545002/diff/1/src/common/linux/synth_elf.cc#newcode153 ...

11 years, 1 month ago #2

Expand All Messages | Collapse All Messages