Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 341 - 360 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
583002	Fix minidump generation from exception. (Closed)	qsr	Mark Mentovai		13 years, 5 months
580003	Make LinuxDumper::FindMapping return an iterator instead of a pointer (Closed)	glandium	Ted Mielczarek		13 years, 5 months
575002	Export ReadSymbolDataInternal as ReadSymbolDataFromMemory	glandium	Ted Mielczarek		13 years, 5 months
560002	Add memory range checks when getting a file_id from a mapped file	glandium	Ted Mielczarek		13 years, 5 months
579002	Add GYP file for tools\windows\symupload. (Closed)	chrisha	Siggi, Mark Mentovai		13 years, 5 months
570002	Add explicit OMAP support to dump_syms. (Closed)	chrisha	Siggi, Mark Mentovai	27	13 years, 5 months
572003	Find auvx entries in process memory instead of /proc/pid/auxv (Closed)	glandium	Ted Mielczarek		13 years, 5 months
576002	Fixing a clang warning. (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Jess, iwilkins		13 years, 5 months
574002	Add MD_OS_PS3 to breakpad and exception types. (Closed)	Lei Zhang (chromium)	jijia		13 years, 5 months
571002	Add MD_OS_PS3 to breakpad and exception types.	jijia	Lei Zhang (chromium), thestig1, Ivan Penkov	6	13 years, 5 months
569002	Fix Clang warning regarding null pointer argument. Fix provided by Ian Wilkinson. (Closed)	Ivan Penkov	iwilking, Mark Mentovai, Ted Mielczarek, Jess, iwilkins	2	13 years, 5 months
572002	Cleanup: Use scoped_ptr where appropriate in DwarfCUToModule. (Closed)	Lei Zhang (chromium)	Mark Mentovai		13 years, 5 months
568002	Rewrite SimpleStringDictionary with NonAllocatingMap. (Closed)	rsesek	Mark Mentovai	76	13 years, 5 months
540003	Improve ARM CPU info reporting. (Closed)	digit	Ted Mielczarek, Mark Mentovai, Lei Zhang (chromium)	45	13 years, 5 months
498002	Cleanup: Remove duplicate wording in license headers. (Closed)	Lei Zhang (chromium)	Cris Neckar, Mark Mentovai		13 years, 5 months
549002	Allow efficient and save "opt-out" from in-proc dump generation. (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Lei Zhang (chromium), Jess, Cris Neckar	14	13 years, 5 months
567002	This change allows compiling the sym_upload and minidump_upload using a global ::string class inste… (Closed)	Ivan Penkov	mattdr, Lei Zhang (chromium), Mark Mentovai, Ted Mielczarek, Jess	4	13 years, 5 months
561002	Linux sym_upload doesn't work if 'char' is unsigned	mattdr	Ted Mielczarek, Lei Zhang (chromium), Ivan Penkov		13 years, 5 months
564003	Fix Bigcluster build error with minidump.cc after r1147. (Closed)	Lei Zhang (chromium)	jijia		13 years, 5 months
564002	Get SimpleStringDictionary compiling on Linux. (Closed)	rsesek	Mark Mentovai	5	13 years, 5 months

« Newest ‹ Newer 341 - 360 Older ›