Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3863)

Issue 560002: Add memory range checks when getting a file_id from a mapped file

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by glandium
Modified:
10 years, 11 months ago
Reviewers:
Ted Mielczarek
Visibility:
Public.

Description

This also does most memory range checks down the way, but while this could be
done completely in dump_symbols as well, I didn't do it. Note this makes API
changes.

Patch Set 1 #

Patch Set 2 : Whitespace fixes for pointers #

Patch Set 3 : Refreshed to current trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_dumper.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/common/linux/dump_symbols.cc View 1 2 18 chunks +36 lines, -50 lines 0 comments Download
M src/common/linux/dump_symbols_unittest.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M src/common/linux/elfutils-inl.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/common/linux/elfutils.cc View 1 2 chunks +69 lines, -82 lines 0 comments Download
M src/common/linux/elfutils.h View 1 3 chunks +20 lines, -21 lines 0 comments Download
M src/common/linux/file_id.cc View 1 2 5 chunks +20 lines, -28 lines 0 comments Download
M src/common/linux/file_id.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/common/linux/file_id_unittest.cc View 1 2 7 chunks +33 lines, -9 lines 0 comments Download
M src/common/memory_range.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
glandium
11 years ago #1
glandium
Whitespace fixes for pointers
10 years, 11 months ago #2
glandium
10 years, 11 months ago #3
Refreshed to current trunk
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted