Linux sym_upload doesn't work if 'char' is unsigned

getopt() returns (int)(-1) when options are exhausted. sym_upload assigns this
to a char. If char is unsigned then this value becomes 255 and is viewed as an
invalid flag.

[Lei Zhang (chromium)]

Drive by lgtm. The getopt(3) man page says getopt() returns an int.

[Ivan Penkov]

On 2013/04/17 22:43:01, thestig wrote:
> Drive by lgtm. The getopt(3) man page says getopt() returns an int.

LGTM.  Let me know if you need this change imported in google3.

[mattdr]

On 2013/04/18 00:05:55, Ivan Penkov wrote:
> On 2013/04/17 22:43:01, thestig wrote:
> > Drive by lgtm. The getopt(3) man page says getopt() returns an int.
> 
> LGTM.  Let me know if you need this change imported in google3.

Thanks. Import to google3 would be nice; I also don't have rw access to commit
to breakpad.

[Ivan Penkov]

No need to check this in.  It was addressed by
https://code.google.com/p/google-breakpad/source/detail?r=1158.

I can do another Breakpad import sometimes next week and I'll ping you when
it's done (I just did one a couple of days ago).

Thanks,
-Ivan


On Tue, Apr 23, 2013 at 12:47 PM, <mattdr@google.com> wrote:

> On 2013/04/18 00:05:55, Ivan Penkov wrote:
>
>> On 2013/04/17 22:43:01, thestig wrote:
>> > Drive by lgtm. The getopt(3) man page says getopt() returns an int.
>>
>
>  LGTM.  Let me know if you need this change imported in google3.
>>
>
> Thanks. Import to google3 would be nice; I also don't have rw access to
> commit to breakpad.
>
> https://breakpad.appspot.com/**561002/<https://breakpad.appspot.com/561002/>
>