Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Issues

« Newest ‹ Newer 321 - 340 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
582002	Ensure a proper LinuxDumper::crash_thread_ value (Closed)	glandium	Ted Mielczarek		13 years
585002	Fix build failure in functioninfo.cc (Closed)	glandium	Ted Mielczarek		13 years
580002	Remove the API to pass known memory mappings to MinidumpWriter and ExceptionHandler	glandium	Ted Mielczarek	2	13 years, 1 month
397002	Avoid gmock warning "Uninteresting mock function call"	Michael Krebs	Ted Mielczarek, vapier		13 years, 1 month
577002	Compile issue when using global string "::string" (Closed)	Ivan Penkov	digit, Mark Mentovai, Jess		13 years, 1 month
592003	Fix a "set but not used" compiler warning in a test (Closed)	mseaborn	Mark Mentovai	2	13 years, 1 month
595002	Fix ELF build ID getter to check the ELF note's namespace string	mseaborn	Mark Mentovai	3	13 years, 1 month
594002	Fix a "set but not used" compiler warning in libdisasm (Closed)	mseaborn	Mark Mentovai		13 years, 1 month
583003	Fix following r1175: the section name is __debug_info, not .debug_info (Closed)	Mark Mentovai	Lei Zhang (chromium)		13 years, 1 month
584002	Check in new Windows binaries. (Closed)	chrisha	Siggi, Mark Mentovai		13 years, 1 month
593002	Mac: Fix more errors from clang to get crash_report.xcodeproj close to compiling. (Closed)	Lei Zhang (chromium)	Mark Mentovai	4	13 years, 1 month
592002	Fix mac dump_syms after r1163. (Closed)	Lei Zhang (chromium)	Mark Mentovai, icodestuff	2	13 years, 1 month
593003	NULL-check the entry in NonAllocatingMap before setting on it. (Closed)	rsesek	Mark Mentovai	4	13 years, 1 month
565002	Add an option to not handle DWARF inter-compilation unit references in Linux dump_syms. (Closed)	Lei Zhang (chromium)	jimb, icodestuff	9	13 years, 1 month
591002	Make x86-64 stack walking work for Native Client minidumps (Closed)	mseaborn	Mark Mentovai, bradnelson		13 years, 1 month
590002	Add MD_OS_NACL platform_id value for identifying NaCl minidumps (Closed)	mseaborn	Mark Mentovai, bradnelson		13 years, 1 month
588003	Fix an "unused variable" compiler warning in exploitability_win.cc (Closed)	mseaborn	Mark Mentovai		13 years, 1 month
589002	dump_syms: Fix load address calculation for prelinked DSOs/PIEs	mseaborn	Roland McGrath, Mark Mentovai		13 years, 1 month
588002	Fix GetLoadingAddress() to work for Native Client executables (Closed)	mseaborn	Mark Mentovai, Roland McGrath	1	13 years, 1 month
585003	Transition some breakpad logging to BPLOG	glandium	Ted Mielczarek		13 years, 1 month

« Newest ‹ Newer 321 - 340 Older ›