Issue 582002: Ensure a proper LinuxDumper::crash_thread_ value

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 582002: Ensure a proper LinuxDumper::crash_thread_ value (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by glandium

Modified:
10 years, 11 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

While running new tests for another issue, I was blocked by the fact that
crash_thread_ was wrong and made CopyFromProcess fail, and found out it was also
the case for other tests, but was hidden by the fact we don't actually check
everything

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/minidump_writer/linux_dumper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/client/linux/minidump_writer/minidump_writer_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Ted Mielczarek

10 years, 11 months ago #2

LGTM

Pushed as 
http://code.google.com/p/google-breakpad/source/detail?r=1185

Expand All Messages | Collapse All Messages