Issue 590002: Add MD_OS_NACL platform_id value for identifying NaCl minidumps

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 590002: Add MD_OS_NACL platform_id value for identifying NaCl minidumps (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by mseaborn

Modified:
10 years, 12 months ago

Reviewers:
Mark Mentovai, bradnelson

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://git.chromium.org/external/google-breakpad.git@master

Visibility:
Public.

More Reviews

Description

Add MD_OS_NACL platform_id value for identifying NaCl minidumps

Change minidump-2-core to accept minidumps with this platform_id value
rather than rejecting them as non-Linux dumps.

Add a missing "break" for a MD_OS_PS3 case.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST= tested with work-in-progress NaCl minidump generator

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1172

Patch Set 1 #

Patch Set 2 : Report OS name too #

Patch Set 3 : Another case #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/google_breakpad/common/minidump_format.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/processor/minidump.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/processor/minidump_processor.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/tools/linux/md2core/minidump-2-core.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

Committed patchset #3 manually as r1172 (presubmit successful).

Expand All Messages | Collapse All Messages