Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 81 - 100 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
6704002	In Mac dump_syms, allow reading debug data out of both the Mach-O file and the dSYM. (Closed)	rsesek	Mark Mentovai	8	11 years, 9 months
10674002	Add GYP build for the src/tools directory on Mac and Linux. (Closed)	rsesek	Mark Mentovai		11 years, 9 months
7684002	Add support for shared libraries in archives. (Closed)	anton	Lei Zhang (chromium), rmcilroy	31	11 years, 9 months
1704002	Cherry pick r1344 into chrome_37 branch (Closed)	rmcilroy	Mark Mentovai		11 years, 9 months
1694003	Cleanup: Remove Mac 10.5 macros. (Closed)	Lei Zhang (chromium)	Mark Mentovai	1	11 years, 9 months
6694002	Both std::tr1::unordered_set and std::unordered_set are not allowed in (Closed)	ivanpe	Mark Mentovai, mmandlis, earthdok, uekawa	2	11 years, 9 months
1694002	[Android]: Remove __system_property_get(ro.build.fingerprint) from WriteOSInformation. (Closed)	rmcilroy	Mark Mentovai, Ted Mielczarek		11 years, 9 months
10664002	Add frame pointer recovery to the AMD64 Stackwalker. (Closed)	rsesek	Mark Mentovai	7	11 years, 9 months
7694002	Change some ELF utils to return the length as a size_t. (Closed)	Lei Zhang (chromium)	Mark Mentovai		11 years, 9 months
1134002	Ensure C:/Dumps/ exists in crash_generation_app (Closed)	j.turney	Ted Mielczarek		11 years, 9 months
3704002	Stringify minidump stream_type constants in minidump_dump output (Closed)	Ted Mielczarek	Mark Mentovai	1	11 years, 9 months
6674002	Cleanup: hide undefined behavior from the compiler better. (Closed)	ivanpe	Ted Mielczarek, jcivelli, qsr, Mark Mentovai, digit		11 years, 10 months
9664002	Unhook current Breakpad object after handling uncaught NSException. (Closed)	pkl	qsr		11 years, 10 months
8664002	Make crash_handler volatile to prevent compiler optimizing it away. (Closed)	anton	Lei Zhang (chromium), rmcilroy		11 years, 10 months
10654002	Update output for test minidump_dump_test. (Closed)	ivanpe	Mark Mentovai		11 years, 10 months
5674002	minidump_dump: convert time_t values to UTC correctly. Interpret the (Closed)	Mark Mentovai	ivanpe	9	11 years, 10 months
9654002	Use PAGE_MAX_SIZE. PAGE_SIZE is now a variable size. (Closed)	justincohen	qsr, Mark Mentovai		11 years, 11 months
7664002	Add virtual dtor to LibcurlWrapper. (Closed)	pbos	ivanpe		11 years, 11 months
3694002	Add missing MD_MISCINFO_FLAGS1_BUILDSTRING (Closed)	Mark Mentovai	ivanpe	1	11 years, 11 months
8654002	Add virtual dtor to LibcurlWrapper. (Closed)	pbos			11 years, 11 months

« Newest ‹ Newer 81 - 100 Older ›