Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 401 - 420 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
433002	Restore Linux ExceptionHandler API + fix Android build. (Closed)	digit	Mark Mentovai, Ted Mielczarek, jcivelli	2	12 years, 11 months
435002	Getting context information from the kernel when catching a SIGABRT on iOS. (Closed)	qsr	Mark Mentovai	10	12 years, 11 months
432002	Fixing a Windows compiler warning in src/client/windows/crash_generation/minidump_generator.cc (Closed)	Ivan Penkov	Mark Mentovai, Cris Neckar		12 years, 11 months
430002	Fixing a race condition in CrashGenerationServer among other issues (Closed)	Ivan Penkov	Mark Mentovai, Cris Neckar, Ted Mielczarek, doshimun	4	12 years, 11 months
431002	Fix narrowing conversion from -1 to size_t (Closed)	Jess	Ben Chan, Mark Mentovai		12 years, 11 months
429002	Clean up warnings about narrowing conversion (Closed)	Jess	Ben Chan, mmentovai, Mark Mentovai	4	13 years
427003	Prepending with "src/" is undesirabe in #include directives (Closed)	Ivan Penkov	digit, Mark Mentovai, Ted Mielczarek		13 years
428002	Compatibility with AddressSanitizer (fast memory error detector for C/C++) (Closed)	Ivan Penkov	ivanpe.google, Ted Mielczarek, Mark Mentovai	8	13 years
424002	android: Add --abi option to android/run-checks.sh (Closed)	digit	Ted Mielczarek, Mark Mentovai	3	13 years
426002	Remove some linux libc calls from client library (take2) (Closed)	digit	Ted Mielczarek, Mark Mentovai		13 years
411002	Remove some linux libc calls from client library. (Closed)	digit	Mark Mentovai, Ted Mielczarek	8	13 years
416002	Android ucontext_t handling refinement. (Closed)	digit	Mark Mentovai, Ted Mielczarek, jimb	11	13 years
408002	Add the capability to include an arbitrary data stream within minidumps (Closed)	Cris Neckar	cpu, Mark Mentovai, cpu1, ted, Ted Mielczarek, Michael Krebs	26	13 years
421002	Linux: Fix a bunch of clang errors from not handling return values. (Closed)	Lei Zhang (chromium)	Mark Mentovai	11	13 years
415002	Move minidump_extension_linux.h contents into minidump_format.h (Closed)	Ted Mielczarek	Mark Mentovai, Lei Zhang (chromium)	1	13 years
418002	Add some more DWARF ARM register numbers (Closed)	Ted Mielczarek	jimb	1	13 years
393002	Rework dump_symbols.cc to handle cross-word-size dumping (Closed)	Ted Mielczarek	jimb, jimb, digit, Mark Mentovai	23	13 years
405002	Add MD_OS_ANDROID definition. (Closed)	digit	Mark Mentovai, Ted Mielczarek	22	13 years
392002	Refactor some ELF bits from file_id.cc into elfutils.{h,cc} (Closed)	Ted Mielczarek	jimb, Mark Mentovai	1	13 years
406002	Allow the crash generation server to be initialized with a handle instead of a pipe name. (Closed)	bsmedberg	Ted Mielczarek	10	13 years

« Newest ‹ Newer 401 - 420 Older ›