Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5201)

Issue 418002: Add some more DWARF ARM register numbers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Ted Mielczarek
Modified:
11 years, 8 months ago
Reviewers:
jimb
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Already filed as Breakpad issue 457, the DWARF parsing code doesn't know about
all valid ARM registers, so it spews warnings when dumping ARM binaries. The ARM
DWARF documentation (
http://infocenter.arm.com/help/topic/com.arm.doc.ihi0040a/IHI0040A_aadwarf.pdf )
lists all the register numbers. This patch doesn't add all of them, but enough
to stop spewing out warnings from the Android libraries I'm dumping.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/dwarf_cfi_to_module.cc View 1 chunk +11 lines, -1 line 1 comment Download

Messages

Total messages: 3
Ted Mielczarek
11 years, 8 months ago #1
jimb
LGTM http://breakpad.appspot.com/418002/diff/1/src/common/dwarf_cfi_to_module.cc File src/common/dwarf_cfi_to_module.cc (right): http://breakpad.appspot.com/418002/diff/1/src/common/dwarf_cfi_to_module.cc#newcode93 src/common/dwarf_cfi_to_module.cc:93: "fps", "cpsr", "", "", "", "", "", "", ...
11 years, 8 months ago #2
Ted Mielczarek
11 years, 8 months ago #3
On 2012/07/18 17:49:49, jimb wrote:
> LGTM
> 
> http://breakpad.appspot.com/418002/diff/1/src/common/dwarf_cfi_to_module.cc
> File src/common/dwarf_cfi_to_module.cc (right):
> 
>
http://breakpad.appspot.com/418002/diff/1/src/common/dwarf_cfi_to_module.cc#n...
> src/common/dwarf_cfi_to_module.cc:93: "fps", "cpsr", "",   "",    "",    "",  

> "",    "",
> If we ever get CFI that references some of these unmapped register numbers
> (accidentally or otherwise), it's going to be pretty confusing. Would it be
> worth it to have DwarfCFIToModule::RegisterName check for empty strings, and
> treat it the same way it treats out-of-bounds register numbers?

That's an excellent idea, I'll add that before landing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted