Issue 392002: Refactor some ELF bits from file_id.cc into elfutils.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 392002: Refactor some ELF bits from file_id.cc into elfutils.{h,cc} (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Ted Mielczarek

Modified:
11 years, 9 months ago

Reviewers:
jimb, Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

In preparation for a larger patch, this patch just refactors out some useful ELF
handling bits into a common place.

Patch Set 2 : Updated patch #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	Makefile.am	View	1	5 chunks	+6 lines, -0 lines	0 comments	Download
M	Makefile.in	View	1	14 chunks	+35 lines, -3 lines	0 comments	Download
A	src/common/linux/elfutils.cc	View	1	1 chunk	+122 lines, -0 lines	0 comments	Download
A	src/common/linux/elfutils.h	View		1 chunk	+81 lines, -0 lines	0 comments	Download
M	src/common/linux/file_id.cc	View		1 chunk	+1 line, -104 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

https://breakpad.appspot.com/392002/diff/1/src/common/linux/elfutils.cc File src/common/linux/elfutils.cc (right): https://breakpad.appspot.com/392002/diff/1/src/common/linux/elfutils.cc#newcode34 src/common/linux/elfutils.cc:34: #include "common/linux/elfutils.h" This one should come first, in a ...

11 years, 9 months ago #2

LGTM

Expand All Messages | Collapse All Messages