Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 341 - 360 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
487002	Add optional file size limit for minidumps (Closed)	Michael Krebs	Mark Mentovai, Ted Mielczarek, Ben Chan, Ivan Penkov	2	12 years, 8 months
492002	Fix assertion failure in WriteMappings() for zero modules (Closed)	Michael Krebs	Ted Mielczarek		12 years, 8 months
496002	Fix typo from r1079. (Closed)	Lei Zhang (chromium)	digit		12 years, 8 months
495002	Linux: Avoid truncating the vendor id. (Closed)	Lei Zhang (chromium)	digit		12 years, 8 months
486002	Minor cleanup in src/client/linux/minidump_writer/minidump_writer_unittest.cc. (Closed)	Lei Zhang (chromium)	Ted Mielczarek	2	12 years, 9 months
413002	Allow processing dumps with missing stack memory for some threads (Closed)	Ted Mielczarek	Mark Mentovai, Michael Krebs	1	12 years, 9 months
494002	Wrong %ebp after skipping a frame for which the instruction pointer is not in a known module. (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai	2	12 years, 9 months
491002	Not checking properly the return value of SuspendThread on Windows (Closed)	Ivan Penkov	ted mielczarek; siyangxie, siyangxie		12 years, 9 months
493002	Fix a compile warning in stack_frame_symbolizer.cc (Closed)	SiyangXie	Ivan Penkov		12 years, 9 months
489002	Fixing Windows client unit tests. They were broken in r1034 due to gMock and gTest upgrade. (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai	12	12 years, 9 months
483002	Fix some compiler errors in exception_handler_unittest by casting like crazy (Closed)	Ted Mielczarek	digit, jimb	1	12 years, 9 months
485002	Merge r1065: Don't bail if a thread's stack pointer is invalid (Closed)	Lei Zhang (chromium)	Michael Krebs, Mark Mentovai		12 years, 9 months
459002	Refactor the logic of resolving source line info into helper class (Closed)	SiyangXie	Ivan Penkov, Ted Mielczarek, Mark Mentovai	78	12 years, 9 months
481002	Make Linux signal handler more robust. (Closed)	digit	Ted Mielczarek, Mark Mentovai, cjhopman	10	12 years, 9 months
482002	Fix the Android unit tests. (Closed)	digit	Ted Mielczarek, Mark Mentovai		12 years, 9 months
440002	Properly redeliver (or don't) signals to the previous handlers. (Closed)	cjhopman	Mark Mentovai, digit	30	12 years, 9 months
478005	Workaround incorrect signal handler save/restore (Closed)	cjhopman	Mark Mentovai	5	12 years, 9 months
478002	Don't bail if a thread's stack pointer is invalid (Closed)	Michael Krebs	Ted Mielczarek, Mark Mentovai	4	12 years, 10 months
457002	Use DW_AT_MIPS_linkage_name if it is available. (Closed)	rafael.espindola	Ted Mielczarek, Ryan Sleevi, jimb, jimb	10	12 years, 10 months
477002	remove unused argument (Closed)	rafael.espindola	Ted Mielczarek, jimb		12 years, 10 months

« Newest ‹ Newer 341 - 360 Older ›