Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(363)

Issue 489002: Fixing Windows client unit tests. They were broken in r1034 due to gMock and gTest upgrade. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by Ivan Penkov
Modified:
11 years, 5 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/
Visibility:
Public.

Description

Fixing Windows client unit tests.  They were broken in r1034 due to gMock and
gTest upgrade.  While fixing the broken tests I also used the opportunity to add
a few more tests that cover filter and callback execution, and nesting of
exception handlers.

Patch Set 1 #

Patch Set 2 : Substituting tabs with spaces #

Patch Set 3 : One more tab was left. Replacing with spaces #

Patch Set 4 : Include What You Use #

Total comments: 10

Patch Set 5 : Making all #includes relative to src/. Fixed a comment. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M client/windows/unittests/client_tests.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M client/windows/unittests/dump_analysis.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M client/windows/unittests/dump_analysis.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M client/windows/unittests/exception_handler_death_test.cc View 1 2 3 4 6 chunks +23 lines, -5 lines 0 comments Download
A client/windows/unittests/exception_handler_nesting_test.cc View 1 2 3 4 1 chunk +327 lines, -0 lines 1 comment Download
M client/windows/unittests/exception_handler_test.cc View 1 2 3 4 5 chunks +31 lines, -6 lines 0 comments Download
A client/windows/unittests/exception_handler_test.h View 1 2 3 4 1 chunk +61 lines, -0 lines 1 comment Download
M client/windows/unittests/minidump_test.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Ivan Penkov
1. Windows client exception handler test fixes. 2. A few more tests that cover filter ...
11 years, 5 months ago #1
Ted Mielczarek
11 years, 5 months ago #2
Ted Mielczarek
https://breakpad.appspot.com/489002/diff/1006/client/windows/unittests/exception_handler_nesting_test.cc File client/windows/unittests/exception_handler_nesting_test.cc (right): https://breakpad.appspot.com/489002/diff/1006/client/windows/unittests/exception_handler_nesting_test.cc#newcode36 client/windows/unittests/exception_handler_nesting_test.cc:36: #include "exception_handler_test.h" Fix these includes to all be relative ...
11 years, 5 months ago #3
Ivan Penkov
Fixed. https://breakpad.appspot.com/489002/diff/1006/client/windows/unittests/exception_handler_nesting_test.cc File client/windows/unittests/exception_handler_nesting_test.cc (right): https://breakpad.appspot.com/489002/diff/1006/client/windows/unittests/exception_handler_nesting_test.cc#newcode36 client/windows/unittests/exception_handler_nesting_test.cc:36: #include "exception_handler_test.h" On 2012/10/18 11:36:30, Ted Mielczarek wrote: ...
11 years, 5 months ago #4
Ted Mielczarek
11 years, 5 months ago #5
LGTM

https://breakpad.appspot.com/489002/diff/6007/client/windows/unittests/except...
File client/windows/unittests/exception_handler_nesting_test.cc (right):

https://breakpad.appspot.com/489002/diff/6007/client/windows/unittests/except...
client/windows/unittests/exception_handler_nesting_test.cc:179:
std::string(kEndOfLine));
I guess the only other thing you could do to make this a little cleaner would be
to use a test fixture and assign these constants in the constructor. Doesn't buy
you much though.

https://breakpad.appspot.com/489002/diff/6007/client/windows/unittests/except...
File client/windows/unittests/exception_handler_test.h (right):

https://breakpad.appspot.com/489002/diff/6007/client/windows/unittests/except...
client/windows/unittests/exception_handler_test.h:33: namespace testing {
I don't really have a better suggestion here, and it's just bikeshedding, so
leave it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted