Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 301 - 320 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
543002	Defer adding sections until ELF::Finish in synth_elf (Closed)	glandium	Ted Mielczarek	1	13 years, 3 months
542002	Get the complete linux gate mapping instead of only one page (Closed)	glandium	Ted Mielczarek		13 years, 3 months
547002	Structured logging prerequisites. Wrapping std::ostream with a new type. (Closed)	Ivan Penkov	Ted Mielczarek, Mark Mentovai, Josh M.		13 years, 3 months
534002	Keeping track of modules without symbols during crash report processing (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Jess	18	13 years, 4 months
539002	Removing redundant calls to string::c_str() (Closed)	Ivan Penkov	Ted Mielczarek, Michael Krebs, Jess		13 years, 4 months
539003	Fix Windows unittest build on VC2012 (Closed)	Ted Mielczarek	Mark Mentovai		13 years, 4 months
422002	Minidumps never contain MD_LINUX_DSO_DEBUG info when breakpad is in a shared library (Closed)	glandium	Ted Mielczarek	8	13 years, 4 months
540002	Fix three unit tests on recent ARM devices. (Closed)	digit	Ted Mielczarek, Mark Mentovai	11	13 years, 4 months
425002	Linux MinidumpWriter should properly set number_of_processors on ARM (Closed)	Ted Mielczarek	digit		13 years, 4 months
522002	Add ReadSymbolData method to Mac dumper code (Closed)	Ted Mielczarek	Mark Mentovai		13 years, 4 months
538002	Make OOP mac crashreporting exit after writing dump (Closed)	Ted Mielczarek	Mark Mentovai	2	13 years, 4 months
517002	Allow dumping just CFI data from debug symbols (Closed)	Ted Mielczarek	Lei Zhang (chromium)	9	13 years, 4 months
536002	Allow building symbol dumping without STABS support (Closed)	Ted Mielczarek	Lei Zhang (chromium), Mark Mentovai		13 years, 4 months
535003	Fix some more processor code to build on Win32 (Closed)	Ted Mielczarek	Mark Mentovai		13 years, 4 months
521002	Minor Android fixup in symbol dumping code (Closed)	Ted Mielczarek	digit	1	13 years, 4 months
535002	Use stdint types everywhere. (Closed)	Ted Mielczarek	Mark Mentovai, ted	15	13 years, 4 months
532002	ESP is zero in dumps created by CrashGenerationClient::RequestDump, on Linux (Closed)	bruce.dawson			13 years, 5 months
514002	Off by one error in EIP/RIP addresses on x86/x64 (Closed)	bruce.dawson	jimb, jimb	9	13 years, 5 months
531002	ESP is zero in dumps created by CrashGenerationClient::RequestDump, on Linux (Closed)	bruce.dawson			13 years, 5 months
527002	Make MmapWrapper a little less silly (Closed)	Ted Mielczarek	Lei Zhang (chromium)		13 years, 5 months

« Newest ‹ Newer 301 - 320 Older ›