Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(137)

Issue 527002: Make MmapWrapper a little less silly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by Ted Mielczarek
Modified:
11 years, 1 month ago
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

The MmapWrapper class in dump_symbols.cc doesn't really work correctly if you
never call .set() (for example, if ReadElf fails). 

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/dump_symbols.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
11 years, 1 month ago #1
Lei Zhang (chromium)
11 years, 1 month ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted