Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 281 - 300 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
568002	Rewrite SimpleStringDictionary with NonAllocatingMap. (Closed)	rsesek	Mark Mentovai	76	12 years, 10 months
540003	Improve ARM CPU info reporting. (Closed)	digit	Ted Mielczarek, Mark Mentovai, Lei Zhang (chromium)	45	12 years, 10 months
498002	Cleanup: Remove duplicate wording in license headers. (Closed)	Lei Zhang (chromium)	Cris Neckar, Mark Mentovai		12 years, 10 months
549002	Allow efficient and save "opt-out" from in-proc dump generation. (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, Lei Zhang (chromium), Jess, Cris Neckar	14	12 years, 10 months
567002	This change allows compiling the sym_upload and minidump_upload using a global ::string class inste… (Closed)	Ivan Penkov	mattdr, Lei Zhang (chromium), Mark Mentovai, Ted Mielczarek, Jess	4	12 years, 10 months
564003	Fix Bigcluster build error with minidump.cc after r1147. (Closed)	Lei Zhang (chromium)	jijia		12 years, 11 months
564002	Get SimpleStringDictionary compiling on Linux. (Closed)	rsesek	Mark Mentovai	5	12 years, 11 months
561003	Move SimpleStringDictionary from common/mac/ to just common/. (Closed)	rsesek	Mark Mentovai	2	12 years, 11 months
559002	Change MDRawSystemInfo.processor_architecture value for PPC64 to 0x8002. (Closed)	Lei Zhang (chromium)	Mark Mentovai		12 years, 11 months
558002	Add PPC64 support to breakpad processor. (Closed)	Lei Zhang (chromium)	jijia		12 years, 11 months
554004	Fix build on Android - add a missing NT_GNU_BUILD_ID define. (Closed)	Lei Zhang (chromium)	Mark Mentovai, Ted Mielczarek, digit	2	12 years, 11 months
553002	Remove auto_ptr usage in Breakpad. (Closed)	Lei Zhang (chromium)	Mark Mentovai		12 years, 11 months
551002	Turn off verbose logging but keep logic for future reference for debug logging. (Closed)	Jess	Ivan Penkov, Mark Mentovai, Ted Mielczarek, Lei Zhang (chromium)		12 years, 11 months
537002	Remove "library" variable. (Closed)	tfarina	Lei Zhang (chromium), Ted Mielczarek		12 years, 11 months
544002	Refactor BasicElf synth_elf unitest (Closed)	glandium	Ted Mielczarek	1	12 years, 11 months
544003	Try to find a build-id through PT_NOTE program headers (Closed)	glandium	Ted Mielczarek	1	12 years, 11 months
545002	Add primitive Elf program header support for synth_elf, with unit tests (Closed)	glandium	Ted Mielczarek	3	12 years, 11 months
546002	Support generic Elf notes, with unit tests (Closed)	glandium	Ted Mielczarek	1	12 years, 11 months
543003	Refactor file_id_unittest (Closed)	glandium	Ted Mielczarek		12 years, 11 months
542003	Add tests for section headers in synth_elf unittest (Closed)	glandium	Ted Mielczarek		12 years, 11 months

« Newest ‹ Newer 281 - 300 Older ›