Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 161 - 180 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
420002	Fix a Windows compiler warning with a cast: (Closed)	rsesek	Mark Mentovai		12 years, 6 months
1104002	Windows: Fix 64-bit compitation of crash_generation_app. (Closed)	Lei Zhang (chromium)	Mark Mentovai	1	12 years, 6 months
1094002	Fix missing semi-colons from r1267. (Closed)	Lei Zhang (chromium)	Mark Mentovai		12 years, 6 months
1084002	Fix VS project generation for the crash generation app. (Closed)	Cris Neckar	Mark Mentovai	2	12 years, 6 months
1054002	Submitting on bahalf of Michele Aiello. (Closed)	Ivan Penkov	Mark Mentovai, Ted Mielczarek, qsr, blundell	4	12 years, 6 months
974002	Add -[BreakpadController setUploadServerParameters:] for iOS. (Closed)	kiyun	blundell	16	12 years, 6 months
1034002	Don't do work inside assert(). Ever. (Closed)	Mark Mentovai	shess, rsesek	2	12 years, 6 months
1044002	Fix #include order from r1268 (Closed)	Mark Mentovai	Ted Mielczarek		12 years, 6 months
557002	Add PPC64 support to breakpad processor. (Closed)	jijia	Lei Zhang (chromium), Mark Mentovai	27	12 years, 7 months
563002	Fix Bigcluster build error with minidump.cc (Closed)	jijia	Lei Zhang (chromium), thestig1, Ivan Penkov		12 years, 7 months
954002	Windows: Fix remaining level 4 warnings. (Closed)	Lei Zhang (chromium)	Mark Mentovai	5	12 years, 7 months
944003	Use a proper ignore_result() to fix a ftruncate warn_unused_result warning with GCC 4.8. (Closed)	Lei Zhang (chromium)	Mark Mentovai	2	12 years, 7 months
964002	Switch scoped_ptr.h to a compatible google3 implementation. (Closed)	Lei Zhang (chromium)	Mark Mentovai	2	12 years, 7 months
944002	Fix warnings from the Windows build. (Closed)	Lei Zhang (chromium)	Mark Mentovai	3	12 years, 7 months
934002	Run svn propdel svn:executable on source code files. (Closed)	Lei Zhang (chromium)			12 years, 7 months
904004	Fix error from r1258. (Closed)	Lei Zhang (chromium)	Cris Neckar, Mark Mentovai		12 years, 7 months
894002	Expose the ability to supply additional user streams in the windows dump generator. (Closed)	Cris Neckar	Mark Mentovai, Ted Mielczarek, cyberparser, Lei Zhang (chromium)	1	12 years, 7 months
914002	Making the Mac build of crash_report work again after the last SVN sync. This includes correction o… (Closed)	Ivan Penkov	tschweitzer, Mark Mentovai, Lei Zhang (chromium), nealsid		12 years, 7 months
924002	Fix gcc vs clang cpuid.h discrepency. (Closed)	Lei Zhang (chromium)	Mark Mentovai, thakis	2	12 years, 7 months
904003	Misc Android-related fixes. (Closed)	digit	Mark Mentovai, Ted Mielczarek	6	12 years, 7 months

« Newest ‹ Newer 161 - 180 Older ›