Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Recent Closed Issues

« Newest ‹ Newer 141 - 160 Older ›

	Subject	Owner	Reviewers	Comments	Last updated
1344002	GoogleCrashdumpUploader would leak instances of LibcurlWrapper (Coverity) (Closed)	Lei Zhang (chromium)	cmumford		11 years
625002	Create ClientData structure. (Closed)	chrisha	Mark Mentovai	36	11 years
1284002	Ignore warning 4702 to avoid unreachable code error on VS2013 (Closed)	Will Harris	Lei Zhang (chromium), Mark Mentovai		11 years
1294002	Check in new Windows binaries. (Closed)	Will Harris	Siggi, Mark Mentovai		11 years
1264002	Add support for Win64 stack unwind data as STACK CFI (Closed)	Will Harris	Mark Mentovai, Ted Mielczarek	10	11 years
1274002	Add support for Win64 stack unwind data as STACK CFI (Closed)	Will Harris	Mark Mentovai		11 years
1224002	64bit PDB format (Closed)	Will Harris			11 years, 1 month
1254002	Fix crash in Windows CrashGenerationServer from r1274. (Closed)	Lei Zhang (chromium)	Cris Neckar, Mark Mentovai		11 years, 1 month
1234002	Fix a bug in BreakpadController that prevented multiple report uploads per call to sendStoredCrashR… (Closed)	ivanpe.google	Mark Mentovai, qsr, blundell, ashersb		11 years, 1 month
1074002	Refactor the Windows MinidumpGenerator interface to get rid of the overloads when generating dumps. (Closed)	Cris Neckar	Mark Mentovai, Lei Zhang (chromium)	3	11 years, 1 month
1244002	Trim unintentional whitespace and fix style nits (Closed)	Lei Zhang (chromium)	mdempsky		11 years, 1 month
1184003	Fixing compiler warnings: (Closed)	Ivan Penkov	Mark Mentovai	2	11 years, 1 month
1174003	Adding a LICENSE file. COPYING is not needed anymore. (Closed)	Ivan Penkov	Mark Mentovai	6	11 years, 1 month
1174002	Initialize file descriptors to -1, not 0, in MachoWalker (Closed)	Mark Mentovai	ivanpe.google, Ivan Penkov		11 years, 1 month
1154002	Fixup breakpad compile for Xcode 5.1 iOS release (Closed)	dmaclach	Mark Mentovai		11 years, 1 month
552002	Fixes for issues 506 and 507 (Closed)	dmaclach	mmentovai		11 years, 1 month
1164002	Update GTM and enable -Wundef and strict C++11 flags (Closed)	dmaclach	Ivan Penkov		11 years, 1 month
1004002	Handle crashes caused by SIGSYS (e.g., due to SECCOMP_RET_TRAP). (Closed)	Jed Davis	Ted Mielczarek, Lei Zhang (chromium), jln		11 years, 2 months
1124002	Create a new tool to upload Mac system library symbols. (Closed)	rsesek	andybons, Mark Mentovai	89	11 years, 2 months
419002	Ignore -Wdeprecated-declarations for bootstrap_create_service in OnDemandServer.mm. (Closed)	rsesek	Mark Mentovai	1	11 years, 2 months

« Newest ‹ Newer 141 - 160 Older ›