Issue 419002: Ignore -Wdeprecated-declarations for bootstrap_create_service in OnDemandServer.mm.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 419002: Ignore -Wdeprecated-declarations for bootstrap_create_service in OnDemandServer.mm. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by rsesek

Modified:
10 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Ignore -Wdeprecated-declarations for bootstrap_create_service in
OnDemandServer.mm.

BUG=crbug.com/137676
TEST=compiles

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/mac/Framework/OnDemandServer.mm	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Mark Mentovai

11 years, 9 months ago #2

LGTM
Committed r993, surprisingly enough given codesite’s read-onlyness.

https://breakpad.appspot.com/419002/diff/1/src/client/mac/Framework/OnDemandS...
File src/client/mac/Framework/OnDemandServer.mm (right):

https://breakpad.appspot.com/419002/diff/1/src/client/mac/Framework/OnDemandS...
src/client/mac/Framework/OnDemandServer.mm:126: #pragma clang diagnostic push
I was going to ask you to use #pragma GCC instead of #pragma clang to have a
wider impact, but you’ve used push/pop, and those aren’t supported on GCC until
4.6. And nobody uses GCC 4.6 on the Mac. I’ll take this as-is.

Expand All Messages | Collapse All Messages