Issue 9784002: Fix Windows dump_syms x64 linking

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 9784002: Fix Windows dump_syms x64 linking (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by Ted Mielczarek

Modified:
9 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

The dia_sdk GYP target currently points at the x86 diaguids.lib, it needs to
point at the x64 one for x64 builds. I verified that both x86 and x64 builds
from Visual C++ work for me with this patch.

Patch Set 2 : Swap slashes #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/windows/common_windows.gyp	View	1	1 chunk	+20 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Mark Mentovai

https://breakpad.appspot.com/9784002/diff/1/src/common/windows/common_windows.gyp File src/common/windows/common_windows.gyp (right): https://breakpad.appspot.com/9784002/diff/1/src/common/windows/common_windows.gyp#newcode40 src/common/windows/common_windows.gyp:40: r'$(VSInstallDir)\DIA SDK\include', Don’t use r-strings, these aren’t supposed to ...

9 years, 11 months ago #3

LGTM

Expand All Messages | Collapse All Messages