Issue 8664002: Make crash_handler volatile to prevent compiler optimizing it away.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 8664002: Make crash_handler volatile to prevent compiler optimizing it away. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by anton

Modified:
10 years, 4 months ago

Reviewers:
Lei Zhang (chromium), rmcilroy

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Make crash_handler volatile to prevent compiler optimizing it away.

This bug manifests itself on Android x64 (in
ExceptionHandlerTest::ExternalDumper), but is possible on any platform. 

The compiler is unaware of the code which runs in the signal handler which reads
this variable. Without volatile the compiler is free to optimise away writes to
this variable which it believes are never read.

BUG=381142, 346626

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	client/linux/handler/exception_handler.h	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rmcilroy

10 years, 4 months ago #4

On 2014/07/02 10:27:30, rmcilroy wrote:
> On 2014/07/01 19:51:42, Lei Zhang (chromium) wrote:
> > lgtm
> 
> Landing for Anton.

Landed as r1343

Expand All Messages | Collapse All Messages