MIPS64: Initial MIPS64 related change.

MIPS64: Initial MIPS64 related change.

With this change Breakpad can be compiled for MIPS64,
but it is not yet functional.

[rmcilroy]

+Mark - I think Mark (or one of the other Breakpad OWNERS) should be reviewing a
big change like this. Mark, care to take a look?

[Mark Mentovai]

LGTM

https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontext.S
File common/android/breakpad_getcontext.S (right):

https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontex...
common/android/breakpad_getcontext.S:260: LOCALS_NUM = 1	// save gp on stack
Nuke the tab.

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h
File third_party/curl/curl.h (right):

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h#newcode77
third_party/curl/curl.h:77: defined(ANDROID) || defined(__ANDROID__)
Do we really need both?

[gordanac]

Hi Mark,
please see comments:


https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontext.S
File common/android/breakpad_getcontext.S (right):

https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontex...>
common/android/breakpad_getcontext.S:260: LOCALS_NUM = 1        // save gp on
stack
On 2015/04/09 17:37:15, Mark Mentovai wrote:
> Nuke the tab.

Done.

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h
File third_party/curl/curl.h (right):

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h#newcode77
third_party/curl/curl.h:77: defined(ANDROID) || defined(__ANDROID__)
On 2015/04/09 17:37:15, Mark Mentovai wrote:
> Do we really need both?

It is up to you.
__ANDROID__ is always defined by the toolchain, I prefer that one.

Regards,
Gordana
________________________________________
From: mark@chromium.org [mark@chromium.org]
Sent: Thursday, April 09, 2015 7:37 PM
To: Gordana Cmiljanovic; rmcilroy@chromium.org
Cc: Petar Jovanovic; reply@breakpad-hr.appspotmail.com
Subject: Re: MIPS64: Initial MIPS64 related change. (issue 6824002)

LGTM


https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontext.S
File common/android/breakpad_getcontext.S (right):

https://breakpad.appspot.com/6824002/diff/1/common/android/breakpad_getcontex...
common/android/breakpad_getcontext.S:260: LOCALS_NUM = 1 // save gp on
stack
Nuke the tab.

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h
File third_party/curl/curl.h (right):

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h#newcode77
third_party/curl/curl.h:77: defined(ANDROID) || defined(__ANDROID__)
Do we really need both?

https://breakpad.appspot.com/6824002/

[Mark Mentovai]

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h
File third_party/curl/curl.h (right):

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h#newcode77
third_party/curl/curl.h:77: defined(ANDROID) || defined(__ANDROID__)
I prefer __ANDROID__ too and if that’s always defined, we should just use that
and not ANDROID.

[gordanac]

Uploaded new patchset:

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h#newcode77
third_party/curl/curl.h:77: defined(ANDROID) || defined(__ANDROID__)
On 2015/04/09 20:59:36, Mark Mentovai wrote:
> I prefer __ANDROID__ too and if that’s always defined, we should just use
that
> and not ANDROID.

Done.

Regards,
Gordana
________________________________________
From: mark@chromium.org [mark@chromium.org]
Sent: Thursday, April 09, 2015 10:59 PM
To: Gordana Cmiljanovic; rmcilroy@chromium.org
Cc: Petar Jovanovic; reply@breakpad-hr.appspotmail.com
Subject: Re: MIPS64: Initial MIPS64 related change. (issue 6824002)

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h
File third_party/curl/curl.h (right):

https://breakpad.appspot.com/6824002/diff/1/third_party/curl/curl.h#newcode77
third_party/curl/curl.h:77: defined(ANDROID) || defined(__ANDROID__)
I prefer __ANDROID__ too and if that’s always defined, we should just
use that and not ANDROID.

https://breakpad.appspot.com/6824002/

[Mark Mentovai]

LGTM

[gordanac]

Could you merge that for me?
Gordana
________________________________________
From: mark@chromium.org [mark@chromium.org]
Sent: Thursday, April 09, 2015 11:27 PM
To: Gordana Cmiljanovic; rmcilroy@chromium.org
Cc: Petar Jovanovic; reply@breakpad-hr.appspotmail.com
Subject: Re: MIPS64: Initial MIPS64 related change. (issue 6824002)

LGTM

https://breakpad.appspot.com/6824002/

[gordanac]

Just a friendly reminder for merging this change.
________________________________________
From: Gordana Cmiljanovic
Sent: Thursday, April 09, 2015 11:32 PM
To: rmcilroy@chromium.org; mark@chromium.org; Petar Jovanovic;
reply@breakpad-hr.appspotmail.com
Subject: RE: MIPS64: Initial MIPS64 related change. (issue 6824002)

Could you merge that for me?
Gordana
________________________________________
From: mark@chromium.org [mark@chromium.org]
Sent: Thursday, April 09, 2015 11:27 PM
To: Gordana Cmiljanovic; rmcilroy@chromium.org
Cc: Petar Jovanovic; reply@breakpad-hr.appspotmail.com
Subject: Re: MIPS64: Initial MIPS64 related change. (issue 6824002)

LGTM

https://breakpad.appspot.com/6824002/

[Mark Mentovai]

Committed r1446.