Issue 6724002: Fix copyright notice in dump_context.cc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 6724002: Fix copyright notice in dump_context.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by primiano

Modified:
9 years, 10 months ago

Reviewers:
vapier

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix copyright notice in dump_context.cc

BUG=chromium:410294

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/processor/dump_context.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

vapier

i don't see the issue. Chromium copyright policy is explicit: do not update the Copyright ...

9 years, 10 months ago #1

primiano

On 2015/01/27 13:46:27, vapier wrote: > i don't see the issue. Chromium copyright policy is ...

9 years, 10 months ago #2

primiano

9 years, 10 months ago #3

On 2015/01/27 14:03:35, primiano wrote:
> On 2015/01/27 13:46:27, vapier wrote:
> > i don't see the issue.  Chromium copyright policy is explicit: do not update
> the
> > Copyright header (year) once the file has been created.
> 
> NOT LGTM.
> Agree with vapier@, copyright notice should reflect the creation date of the
> file and should not be touched afterwards.
> Please see: http://www.chromium.org/developers/coding-style
> Similar rules apply internally.

Hold on, did I just "NOT LGTM" a CL from myself? ^__^
facepalm.

I have absolutely no memory of this. 

I will silently close this issue in shame.

Expand All Messages | Collapse All Messages