Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(476)

Issue 633002: Fix the Android/MIPS build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by digit
Modified:
6 years, 1 month ago
Reviewers:
Mark Mentovai, thakis, Ivan Penkov, Petar Jovanovic, gordana.cmiljanovic, Petar.Jovanovic
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix the Android/MIPS build.

This patch fixes the build for Android on MIPS when
using the latest official Android NDK (r9):

- Update src/common/android/include/elf.h to add a missing
  definition for SHT_MIPS_DWARF.

- Add src/common/android/include/sgidefs.h required by LSS
  when compiling for MIPS.

- Update android/run-checks.sh to work properly with
  the --abi=mips option. All tests were passed succesfully
  with an emulator system image running Android 4.2.

- Update other Android-specific files.

R=Petar.Jovanovic@imgtec.com, mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 chunk +7 lines, -1 line 0 comments Download
M Makefile.in View 2 chunks +4 lines, -4 lines 0 comments Download
M README.ANDROID View 1 chunk +1 line, -2 lines 0 comments Download
M android/google_breakpad/Android.mk View 2 chunks +2 lines, -6 lines 0 comments Download
M android/run-checks.sh View 1 chunk +3 lines, -0 lines 0 comments Download
M android/sample_app/jni/Application.mk View 1 chunk +1 line, -1 line 0 comments Download
M configure View 11 chunks +13 lines, -7 lines 0 comments Download
M src/common/android/include/elf.h View 1 chunk +4 lines, -0 lines 0 comments Download
A src/common/android/include/sgidefs.h View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5
digit
As promised in https://breakpad.appspot.com/632002/, here's the patch fixing the Android/MIPS build. NOTE: This does _not_ ...
6 years, 1 month ago #1
digit
Adding two more reviewers.
6 years, 1 month ago #2
Mark Mentovai
LGTM
6 years, 1 month ago #3
Petar.Jovanovic_imgtec.com
lgtm. Btw, I can not place a comment on the Rietveld change, it says: Rietveld ...
6 years, 1 month ago #4
digit
6 years, 1 month ago #5
Message was sent while issue was closed.
Committed patchset #1 manually as r1216 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted