Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 628002: Fixing minidump_dump to handle nacl dumps. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by bradnelson
Modified:
11 years, 2 months ago
Reviewers:
Mark Mentovai, mseaborn
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixing minidump_dump to handle nacl dumps.

Since nacl was not listed in decoding the code identifier, minidump_dump
produces errors like this (and non-zero return code):
2013-09-05 13:41:04: minidump.cc:2044: ERROR: MinidumpModule code_identifier
requires known platform, found 0x8205

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST=tested with minidumps from nacl locally
R=mark@chromium.org,mseaborn@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1211

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/processor/minidump.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
bradnelson
Committed patchset #2 manually as r1211 (presubmit successful).
11 years, 2 months ago #1
Mark Mentovai
11 years, 2 months ago #2
Message was sent while issue was closed.
LGTM again (I originally reviewed this at https://breakpad.appspot.com/626002/)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted