DescriptionThe iOS port has a SIGABRT handler which turns out to be useful on desktop OS X for a number of reasons (https://bugzilla.mozilla.org/show_bug.cgi?id=717758, for example). The code as-written mostly works, it just needed the extra handling in MinidumpGenerator::GetThreadState to do the right thing. I spent extra time writing the unit test because without that block of code it still produced minidumps, but the exception context was all wrong. I still can't figure out how to write a really rigorous unit test, but I gave up. Patch Set 1 #Patch Set 2 : Remove extraneous xcode project hunks #
Total comments: 3
MessagesTotal messages: 5
|