Issue 596002: Always read CFI section, even when not outputing CFI information.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 596002: Always read CFI section, even when not outputing CFI information. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by qsr

Modified:
11 years, 1 month ago

Reviewers:
Mark Mentovai, Ted Mielczarek, blundell

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://google-breakpad.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Always read CFI section, even when not outputing CFI information.

 On iOS at least, the CFI section contains information needed to
correctly dump the symbols. Even if the CFI section is not dumped,
reading it is necessary to get correcty symbolication.

R=mark@chromium.org, ted.mielczarek@gmail.com

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1182

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/mac/dump_syms.mm	View		2 chunks	+6 lines, -8 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Ted Mielczarek

LGTM, I'm not relying on this behavior, it just seemed like the right thing to ...

11 years, 6 months ago #2

blundell

11 years, 1 month ago #5

Message was sent while issue was closed.

https://breakpad.appspot.com/596002/diff/1/src/common/mac/dump_syms.mm
File src/common/mac/dump_syms.mm (left):

https://breakpad.appspot.com/596002/diff/1/src/common/mac/dump_syms.mm#oldcod...
src/common/mac/dump_syms.mm:408: module_->SetLoadAddress(segment.vmaddr);
The cause of the incorrect behavior that Ben was experiencing is that this line
should not have been put under the additional condition |symbol_data_ != NO_CFI|
as part of https://breakpad.appspot.com/517002/.

Expand All Messages | Collapse All Messages