Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3764)

Issue 573002: Move mappings aggregation and reordering from linux_dumper to minidump_writer

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by glandium
Modified:
10 years, 10 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Make the executable module first and merge adjacent mappings at the
minidump_writer level instead of linux_dumper

Patch Set 1 #

Patch Set 2 : Final version, hopefully #

Patch Set 3 : A small fix #

Patch Set 4 : Another small change #

Patch Set 5 : Forgot to commit another local change #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_dumper.cc View 1 4 chunks +3 lines, -38 lines 0 comments Download
M src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc View 1 1 chunk +0 lines, -70 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.cc View 1 2 3 4 2 chunks +45 lines, -16 lines 3 comments Download
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 1 3 chunks +65 lines, -0 lines 0 comments Download

Messages

Total messages: 10
glandium
10 years, 12 months ago #1
glandium
Whitespace fixes for pointers
10 years, 11 months ago #2
glandium
Simplified a bit
10 years, 11 months ago #3
glandium
On 2013/05/02 08:45:30, glandium wrote: > Simplified a bit Please ignore this patch for now, ...
10 years, 11 months ago #4
glandium
Final version, hopefully
10 years, 11 months ago #5
glandium
10 years, 11 months ago #6
glandium
This should be the last one
10 years, 11 months ago #7
glandium
This time, it should be the last one
10 years, 11 months ago #8
Ted Mielczarek
LGTM, just one question. https://breakpad.appspot.com/573002/diff/24001/src/client/linux/minidump_writer/minidump_writer.cc File src/client/linux/minidump_writer/minidump_writer.cc (right): https://breakpad.appspot.com/573002/diff/24001/src/client/linux/minidump_writer/minidump_writer.cc#newcode857 src/client/linux/minidump_writer/minidump_writer.cc:857: PageAllocator allocator; Is there any ...
10 years, 10 months ago #9
glandium
10 years, 10 months ago #10
https://breakpad.appspot.com/573002/diff/24001/src/client/linux/minidump_writ...
File src/client/linux/minidump_writer/minidump_writer.cc (right):

https://breakpad.appspot.com/573002/diff/24001/src/client/linux/minidump_writ...
src/client/linux/minidump_writer/minidump_writer.cc:857: PageAllocator
allocator;
On 2013/06/07 15:42:02, Ted Mielczarek wrote:
> Is there any reason not to just use dumper_->allocator() here?

I wanted the allocations from this one to be freed without waiting the dumper to
be released.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted