Issue 5724002: Fix clang compilation error introduced in r1380.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 5724002: Fix clang compilation error introduced in r1380. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by simonb

Modified:
11 years, 1 month ago

Reviewers:
rmcilroy

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Fix clang compilation error introduced in r1380.

Fixes:
  .../linux_dumper.cc:308:25: error: address of array 'module->name' will always
evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
                module->name && module->name[0] == '/' &&
                ~~~~~~~~^~~~

BUG=chromium:394703

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	client/linux/minidump_writer/linux_dumper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmcilroy

11 years, 1 month ago #3

On 2014/09/22 16:53:37, rmcilroy wrote:
> On 2014/09/22 14:49:36, simonb wrote:
> 
> LGTM, thanks.

Landed as r1384.

Expand All Messages | Collapse All Messages