Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 571003: Set minidump special module debug name for linux-gate at the minidump_writer level instead of linux…

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by glandium
Modified:
8 years ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Set minidump special module debug name for linux-gate at the minidump_writer
level instead of linux…

Patch Set 1 #

Patch Set 2 : Whitespace fixes for pointers #

Total comments: 3

Patch Set 3 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_dumper.cc View 1 2 3 chunks +4 lines, -18 lines 0 comments Download
M src/client/linux/minidump_writer/linux_dumper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.cc View 1 2 3 chunks +28 lines, -11 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 1 2 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 3
glandium
8 years, 3 months ago #1
glandium
Whitespace fixes for pointers
8 years, 2 months ago #2
Ted Mielczarek
8 years, 1 month ago #3
LGTM with a few nits.

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
File src/client/linux/minidump_writer/linux_dumper.cc (right):

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
src/client/linux/minidump_writer/linux_dumper.cc:212: // Skip whitespaces.
whitespace, no s.

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
File src/client/linux/minidump_writer/minidump_writer.cc (right):

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
src/client/linux/minidump_writer/minidump_writer.cc:940: // linux_gate_loc is
the beginning of the kernel's mapping of
You removed linux_gate_loc, can you fix the comment?

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
File src/client/linux/minidump_writer/minidump_writer.h (right):

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
src/client/linux/minidump_writer/minidump_writer.h:49: // This should always be
less than NAME_MAX!
Can you fix this comment to be third-person while you're here? Maybe "Use this
name for writing the VDSO mapping to the minidump."
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted