Issue 571003: Set minidump special module debug name for linux-gate at the minidump_writer level instead of linux…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 571003: Set minidump special module debug name for linux-gate at the minidump_writer level instead of linux…

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by glandium

Modified:
11 years, 4 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Set minidump special module debug name for linux-gate at the minidump_writer
level instead of linux…

Patch Set 1 #

Patch Set 2 : Whitespace fixes for pointers #

Total comments: 3

Patch Set 3 : Addressed nits #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/linux/minidump_writer/linux_dumper.cc	View	1 2	3 chunks	+4 lines, -18 lines	0 comments	Download
M	src/client/linux/minidump_writer/linux_dumper.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc	View	1 2	1 chunk	+0 lines, -54 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.cc	View	1 2	3 chunks	+28 lines, -11 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer_unittest.cc	View	1 2	1 chunk	+54 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

11 years, 6 months ago #3

LGTM with a few nits.

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
File src/client/linux/minidump_writer/linux_dumper.cc (right):

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
src/client/linux/minidump_writer/linux_dumper.cc:212: // Skip whitespaces.
whitespace, no s.

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
File src/client/linux/minidump_writer/minidump_writer.cc (right):

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
src/client/linux/minidump_writer/minidump_writer.cc:940: // linux_gate_loc is
the beginning of the kernel's mapping of
You removed linux_gate_loc, can you fix the comment?

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
File src/client/linux/minidump_writer/minidump_writer.h (right):

https://breakpad.appspot.com/571003/diff/3001/src/client/linux/minidump_write...
src/client/linux/minidump_writer/minidump_writer.h:49: // This should always be
less than NAME_MAX!
Can you fix this comment to be third-person while you're here? Maybe "Use this
name for writing the VDSO mapping to the minidump."

Expand All Messages | Collapse All Messages