This change allows compiling the sym_upload and minidump_upload using a global ::string class inste…

This change allows compiling sym_upload.cc and minidump_upload.cc using a global
::string class instead of std::string.  For more details take a look at
common/using_std_string.h

A few other fixes:

 - getopt() returns (int)(-1) when options are exhausted.  This was already sent
out for code review by mattdr but only for sym_upload.cc
(https://breakpad.appspot.com/561002/).  I'm applying the fix for both files.

 - Fixed a couple of lint warning about improper usage of white-spaces.

Thanks,
-Ivan
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1158

[Ivan Penkov]

.

[Mark Mentovai]

LGTM

https://breakpad.appspot.com/567002/diff/1/src/tools/linux/symupload/minidump...
File src/tools/linux/symupload/minidump_upload.cc (right):

https://breakpad.appspot.com/567002/diff/1/src/tools/linux/symupload/minidump...
src/tools/linux/symupload/minidump_upload.cc:146: int main(int argc, const char
* argv[]) {
Since you’re fixing this line, fix the * too. It should be either on char or on
argv but never alone like this. This file’s style favors putting it on argv.

https://breakpad.appspot.com/567002/diff/1/src/tools/linux/symupload/sym_uplo...
File src/tools/linux/symupload/sym_upload.cc (right):

https://breakpad.appspot.com/567002/diff/1/src/tools/linux/symupload/sym_uplo...
src/tools/linux/symupload/sym_upload.cc:223: int main(int argc, const char *
argv[]) {
Likewise.

[Ivan Penkov]

Done.

https://breakpad.appspot.com/567002/diff/1/src/tools/linux/symupload/minidump...
File src/tools/linux/symupload/minidump_upload.cc (right):

https://breakpad.appspot.com/567002/diff/1/src/tools/linux/symupload/minidump...
src/tools/linux/symupload/minidump_upload.cc:146: int main(int argc, const char
* argv[]) {
On 2013/04/23 19:56:16, Mark Mentovai wrote:
> Since you’re fixing this line, fix the * too. It should be either on char or
on
> argv but never alone like this. This file’s style favors putting it on argv.

Done.

https://breakpad.appspot.com/567002/diff/1/src/tools/linux/symupload/sym_uplo...
File src/tools/linux/symupload/sym_upload.cc (right):

https://breakpad.appspot.com/567002/diff/1/src/tools/linux/symupload/sym_uplo...
src/tools/linux/symupload/sym_upload.cc:223: int main(int argc, const char *
argv[]) {
On 2013/04/23 19:56:16, Mark Mentovai wrote:
> Likewise.

Done.

[Mark Mentovai]

LGTM