Issue 511003: Add APIs for querying Module data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 511003: Add APIs for querying Module data (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Ted Mielczarek

Modified:
10 years, 1 month ago

Reviewers:
jimb, Mark Mentovai, Lei Zhang (chromium), glandium

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

We have a use case for loading debug symbols and querying the info out of the
Module object directly. This patch adds some methods to Module to query symbol
data by address. As part of this, it changes the StackFrameEntry storage from
vector to set so we can search it more easily.

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/common/module.cc	View	4 chunks	+63 lines, -6 lines	2 comments	Download
M	src/common/module.h	View	3 chunks	+23 lines, -1 line	0 comments	Download
M	src/common/module_unittest.cc	View	2 chunks	+169 lines, -22 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

glandium

11 years, 10 months ago #4

LGTM. Just nits.

https://breakpad.appspot.com/511003/diff/1/src/common/module.cc
File src/common/module.cc (right):

https://breakpad.appspot.com/511003/diff/1/src/common/module.cc#newcode134
src/common/module.cc:134: return NULL;
This would probably read better if it was
  if ((*it)->address <= address && address < (*it)->address + (*it)->size)
    return *it;
  return NULL;

https://breakpad.appspot.com/511003/diff/1/src/common/module.cc#newcode214
src/common/module.cc:214: return NULL;
Likewise. It might be worth templating or something, to avoid code duplication.

Expand All Messages | Collapse All Messages