Issue 510002: Provide a ReadSymbolData function from dump_symbols.cc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 510002: Provide a ReadSymbolData function from dump_symbols.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Ted Mielczarek

Modified:
11 years, 10 months ago

Reviewers:
jimb, Mark Mentovai, Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

We have a use case where we'd like to read symbol data and use it directly,
without having to serialize it to a file. Step 1 is to provide an API to get the
data out in non-serialized form. This patch adds a ReadSymbolData function to
dump_symbols.cc which returns a Module object and refactors things slightly to
avoid code duplication.

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/common/linux/dump_symbols.cc	View	5 chunks	+34 lines, -18 lines	0 comments	Download
M	src/common/linux/dump_symbols.h	View	1 chunk	+10 lines, -0 lines	1 comment	Download
M	src/common/linux/dump_symbols_unittest.cc	View	4 chunks	+28 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

jimb is tied up in other work currently, so trolling for reviews. I have a ...

11 years, 10 months ago #2

Lei Zhang (chromium)

11 years, 10 months ago #3

lgtm

https://breakpad.appspot.com/510002/diff/1/src/common/linux/dump_symbols.h
File src/common/linux/dump_symbols.h (right):

https://breakpad.appspot.com/510002/diff/1/src/common/linux/dump_symbols.h#ne...
src/common/linux/dump_symbols.h:58: // As above, but simply return the debugging
information in module
nit: module in caps?

Expand All Messages | Collapse All Messages