Issue 497002: minidump_stackwalk: Show argument registers for ARM stack traces

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 497002: minidump_stackwalk: Show argument registers for ARM stack traces

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by Michael Krebs

Modified:
11 years, 3 months ago

Reviewers:
jimb, Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

minidump_stackwalk: Show argument registers for ARM stack traces

Show argument registers (caller-saves) in ARM stack frames if they're valid.

BUG=google-breakpad:504, chromium-os:36182
TEST=Ran unittests

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/processor/minidump_stackwalk.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Michael Krebs

Apparently, bug numbers aren't automatically turned into links. So here they are: http://code.google.com/p/google-breakpad/issues/detail?id=504 http://crosbug.com/36182#c9

11 years, 5 months ago #2

This LGTM, you should land it.

Expand All Messages | Collapse All Messages