Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 4714002: Refactor common code for ensuring core dump for unit tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by Ben Chan
Modified:
2 years, 2 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Refactor common code for ensuring core dump for unit tests.

This CL moves the common code for ensuring a core dump file being
generated for a unit test to CrashGenerator::CreateCoreDumpForTest.

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_core_dumper_unittest.cc View 1 1 chunk +7 lines, -19 lines 0 comments Download
M src/common/linux/elf_core_dump_unittest.cc View 1 2 chunks +7 lines, -17 lines 0 comments Download
M src/common/linux/tests/crash_generator.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/common/linux/tests/crash_generator.h View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 7
Ben Chan
2 years, 2 months ago #1
Mark Mentovai
https://breakpad.appspot.com/4714002/diff/1/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc File src/client/linux/minidump_writer/linux_core_dumper_unittest.cc (right): https://breakpad.appspot.com/4714002/diff/1/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc#newcode69 src/client/linux/minidump_writer/linux_core_dumper_unittest.cc:69: pid_t child_pid = 0; Unused, no need to initialize. ...
2 years, 2 months ago #2
Ben Chan
https://breakpad.appspot.com/4714002/diff/1/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc File src/client/linux/minidump_writer/linux_core_dumper_unittest.cc (right): https://breakpad.appspot.com/4714002/diff/1/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc#newcode69 src/client/linux/minidump_writer/linux_core_dumper_unittest.cc:69: pid_t child_pid = 0; On 2015/02/02 17:12:32, Mark Mentovai ...
2 years, 2 months ago #3
Ben Chan
On 2015/02/02 17:52:03, Ben Chan wrote: > https://breakpad.appspot.com/4714002/diff/1/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc > File src/client/linux/minidump_writer/linux_core_dumper_unittest.cc (right): > > https://breakpad.appspot.com/4714002/diff/1/src/client/linux/minidump_writer/linux_core_dumper_unittest.cc#newcode69 ...
2 years, 2 months ago #4
Mark Mentovai
https://breakpad.appspot.com/4714002/diff/1/src/common/linux/tests/crash_generator.cc File src/common/linux/tests/crash_generator.cc (right): https://breakpad.appspot.com/4714002/diff/1/src/common/linux/tests/crash_generator.cc#newcode265 src/common/linux/tests/crash_generator.cc:265: fprintf(stderr, "%s test is skipped due to failure to ...
2 years, 2 months ago #5
Ben Chan
On 2015/02/02 22:27:45, Mark Mentovai wrote: > https://breakpad.appspot.com/4714002/diff/1/src/common/linux/tests/crash_generator.cc > File src/common/linux/tests/crash_generator.cc (right): > > https://breakpad.appspot.com/4714002/diff/1/src/common/linux/tests/crash_generator.cc#newcode265 ...
2 years, 2 months ago #6
Mark Mentovai
2 years, 2 months ago #7
Yes, that sounds good.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted